Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AEA-660 Set logger for each component and prepend agent_name to log messages #1491

Merged
merged 16 commits into from
Jul 14, 2020
Merged

AEA-660 Set logger for each component and prepend agent_name to log messages #1491

merged 16 commits into from
Jul 14, 2020

Conversation

marcofavorito
Copy link
Contributor

Proposed changes

Set logger for each component and prepend agent_name to log messages

Fixes

Fixes #1327, #1118 , #1050

Types of changes

What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have checked that the documentation about the aea cli tool works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@marcofavorito marcofavorito marked this pull request as draft July 13, 2020 18:01
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2020 •
edited
Loading

Codecov Report

Merging #1491 into develop will decrease coverage by 0.33%.
The diff coverage is 89.28%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1491      +/-   ##
===========================================
- Coverage    90.33%   90.00%   -0.34%     
===========================================
  Files          243      244       +1     
  Lines        17209    17318     +109     
===========================================
+ Hits         15546    15587      +41     
- Misses        1663     1731      +68
Flag Coverage Δ
#unittests 90.00% <89.28%> (-0.34%) ⬇️
Impacted Files Coverage Δ
...etchai/connections/p2p_libp2p_client/connection.py 83.68% <66.66%> (-10.02%) ⬇️
packages/fetchai/connections/oef/connection.py 65.58% <70.00%> (+0.32%) ⬆️
...kages/fetchai/connections/p2p_libp2p/connection.py 85.71% <71.42%> (-14.29%) ⬇️
aea/aea_builder.py 86.01% <85.71%> (+0.02%) ⬆️
aea/skills/base.py 96.47% <85.71%> (-0.57%) ⬇️
aea/multiplexer.py 92.45% <86.00%> (+0.04%) ⬆️
aea/skills/tasks.py 98.03% <88.88%> (+0.03%) ⬆️
aea/aea.py 97.95% <100.00%> (+0.07%) ⬆️
aea/agent_loop.py 97.93% <100.00%> (+0.02%) ⬆️
aea/components/base.py 100.00% <100.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5f915b...bb9847a. Read the comment docs.

DavidMinarsch
DavidMinarsch reviewed Jul 14, 2020
View reviewed changes
aea/aea_builder.py Outdated Show resolved Hide resolved
@marcofavorito marcofavorito marked this pull request as ready for review July 14, 2020 13:37
@DavidMinarsch DavidMinarsch merged commit f7235b9 into develop Jul 14, 2020
@DavidMinarsch DavidMinarsch deleted the feature/agent-name-log branch July 15, 2020 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidMinarsch DavidMinarsch DavidMinarsch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcofavorito @codecov-commenter @DavidMinarsch